Skip to content

Missing header include in Server.h #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spiritinlife opened this issue Sep 26, 2014 · 3 comments
Closed

Missing header include in Server.h #2327

spiritinlife opened this issue Sep 26, 2014 · 3 comments
Labels
Component: Core Related to the code for the standard Arduino API Type: Bug

Comments

@spiritinlife
Copy link

In file arduino/hardware/arduino/cores/arduino/Server.h,
Server class inherits from Print class but there is no #include "Print.h"

It may be my mistake but when i added it everything compiled correctly.

Anyway thought you should know.

Keep on coding,
Spiritinlife

@matthijskooijman
Copy link
Collaborator

I suspect that in your own code, you #included Server.h directly? I guess that in most cases, Arduino.h is also included, which masks this bug. Care to prepare a pullrequest to add the include to Server.h? If so, best use the ide-1.5.x branch instead of master, though.

@matthijskooijman matthijskooijman added Component: Core Related to the code for the standard Arduino API Type: Bug labels Sep 26, 2014
@spiritinlife
Copy link
Author

i did not add #include Server.h directly, i used the the arduino_uip
library which does though.
I will be more than happy to make a pull request following your guidelines.

Keep on coding,
Spiritinlife

On 26 September 2014 16:07, Matthijs Kooijman [email protected]
wrote:

I suspect that in your own code, you #included Server.h directly? I guess
that in most cases, Arduino.h is also included, which masks this bug. Care
to prepare a pullrequest to add the include to Server.h? If so, best use
the ide-1.5.x branch instead of master, though.


Reply to this email directly or view it on GitHub
#2327 (comment).

@cmaglie
Copy link
Member

cmaglie commented Oct 8, 2014

Fixed in #2330

@cmaglie cmaglie closed this as completed Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Related to the code for the standard Arduino API Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants