[macOS] Modify behaviour when last editor gets closed #8023
Conversation
facchinm
force-pushed
the
new_behaviour_osx_close
branch
from
e7fe15e to
d129e78
Compare
facchinm
changed the title
facchinm
added
the
OS: OSX
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8023-BUILD-774-linux32.tar.xz ℹ️ The |
app/src/processing/app/Base.java
Outdated
| @@ -921,7 +922,10 @@ public boolean handleClose(Editor editor) { | |||
| storeSketches(); | |||
|
|
|||
| // This will store the sketch count as zero | |||
| editor.setVisible(false); | |||
| //editor.dispose(); | |||
There was a problem hiding this comment.
Let's remove the commented code :)
There was a problem hiding this comment.
I left it there for a reason :) On my trials, if dispose() gets called the toolbar doesn't disappear but clicking on any element has no effect. I believe it's a broader bug, since the toolbar handlers are declared inside the first Editor instance. If we refactor the code dispose() should be called, so it's more like a reminder :)
| } | ||
| } catch (Exception e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Better error handling here?
There was a problem hiding this comment.
Absolutely (no idea about how to handle it anyway)
|
@sandeepmistry same here, despite I've noticed that if you have multiple tabs and decide to close the first one, the app "goes away" (as in: stays in background, do not kill itself, but tabs are gone if you click again on it) instead of showing the other tabs kept open. cc @facchinm |
|
@gvarisco can you expand on that? The "new" behaviour should only kick in if a single Editor windows is open (multiple tabs on the same editor don't count they are part of an "atomic" sketch). |
|
Clarified with @facchinm - all good on my side. LGTM. |
Don't call System.exit() but trust the ThinkDifferent handler Handle reopen only if no editor is visible Don't dispose last closing editor (so its toolbars are still in active state)
facchinm
force-pushed
the
new_behaviour_osx_close
branch
from
d129e78 to
36da22c
Compare
Fixes #8021 and #936