Skip to content

CurieBLE: Deprecated BLEConnected and BLEDisconnected events not triggered #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandeepmistry opened this issue Feb 17, 2017 · 5 comments
Closed

CurieBLE: Deprecated BLEConnected and BLEDisconnected events not triggered #445

sandeepmistry opened this issue Feb 17, 2017 · 5 comments
Assignees
@sandeepmistry
Labels
bug Under Review
Milestone
Deneb

Comments

@sandeepmistry
Copy link
Contributor

While testing the v1.0.7 LED callback example (https://github.com/01org/corelibs-arduino101/blob/1.0.7/libraries/CurieBLE/examples/CallbackLED/CallbackLED.ino), I noticed the BLEConnected and BLEDisconnected events are not being trigged.
sgbihu added a commit to sgbihu/corelibs-arduino101 that referenced this issue Feb 20, 2017
@sgbihu
Fix arduino#445 Deprecated BLEConnected and BLEDisconnected events no…
3563ce4 
…t triggered

1. Root casue: The callback regiter before the begin and the begin
    reset the callback.
2. Solution: Remove it from the init method and init it when create.
sgbihu added a commit to sgbihu/corelibs-arduino101 that referenced this issue Feb 20, 2017
@sgbihu
Fix arduino#445 Deprecated BLEConnected and BLEDisconnected events no…
9cee7f5 
…t triggered

1. Root casue: The callback regiter before the begin and the begin
    reset the callback.
2. Solution: Remove it from the init method and init it when create.
@sgbihu sgbihu mentioned this issue Feb 20, 2017
Closed
@sgbihu
Copy link
Contributor

sgbihu commented Feb 20, 2017

Fixed

@kitsunami kitsunami added this to the Deneb milestone Feb 21, 2017
@kitsunami kitsunami added the bug label Feb 21, 2017
@SidLeung
Copy link
Contributor

This issue is tracked by Jira ticket 858.

@russmcinnis
Copy link
Contributor

Confirmed that this is working with PR447 using the sketch linked here. Also ran basic BAT tests along with some manual testing.

sgbihu added a commit to sgbihu/corelibs-arduino101 that referenced this issue Feb 23, 2017
@sgbihu
Fix arduino#445 Deprecated BLEConnected and BLEDisconnected events no…
5642f75 
…t triggered

1. Root casue: The callback regiter before the begin and the begin
    reset the callback.
2. Solution: Remove it from the init method and init it when create.
@russmcinnis
Copy link
Contributor

this works with PR 455 system tests and tested for seeing connects and disconnects. Looks good.

@sandeepmistry
Copy link
Contributor Author

Tested again with the 2.0.1 RC1 release, this now works as expected. Closing.

Connected event, central: AC:BC:32:7C:FA:26
Characteristic event, written: LED on
Characteristic event, written: LED off
Disconnected event, central: AC:BC:32:7C:FA:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandeepmistry sandeepmistry

Labels
bug Under Review
Projects
None yet
Milestone
Deneb
Development

No branches or pull requests
5 participants
@sandeepmistry @russmcinnis @kitsunami @SidLeung @sgbihu