Skip to content

Fix Klockwork issues in CurieEEPROM #142 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Klockwork issues in CurieEEPROM #142 #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions libraries/CurieEEPROM/src/CurieEEPROM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,13 @@ void CurieEEPROM::write(uint32_t address, uint32_t data)
address*=sizeof(uint32_t);

uint32_t rom_wr_ctrl = 0;
//make sure address is valid
if((address > 0x7FC) || (address%4))
{
return;
}

//check if address is available for writing a new value. If not erase the whole 2K block and re-write the rest of the data
if(currentValue!=0xFFFFFFFF)
{
//read entire 2k of data
uint32_t blockdata[EEPROM_SIZE/4];
for(int i = 0; i < EEPROM_SIZE/4; i++)
uint32_t blockdata[EEPROM_SIZE];
for(int i = 0; i < EEPROM_SIZE; i++)
{
blockdata[i] = read(i*sizeof(uint32_t));
}
Expand All @@ -72,7 +67,7 @@ void CurieEEPROM::write(uint32_t address, uint32_t data)
clear();

//write back all data with update data on passed address
for(int i = 0; i < EEPROM_SIZE/4; i++)
for(int i = 0; i < EEPROM_SIZE; i++)
{
//store data into ROM_WR_DATA register
*(uint32_t*)(ROM_WR_DATA) = blockdata[i];
Expand Down Expand Up @@ -115,8 +110,8 @@ void CurieEEPROM::write8(uint32_t address, uint8_t data)
if(currentValue!=0xFF)
{
//read entire 2k of data
uint32_t blockdata[EEPROM_SIZE/4];
for(int i = 0; i < EEPROM_SIZE/4; i++)
uint32_t blockdata[EEPROM_SIZE];
for(int i = 0; i < EEPROM_SIZE; i++)
{
blockdata[i] = read(i*sizeof(uint32_t));
}
Expand All @@ -135,7 +130,7 @@ void CurieEEPROM::write8(uint32_t address, uint8_t data)
clear();

//write back all data with update data on passed address
for(int i = 0; i < EEPROM_SIZE/4; i++)
for(int i = 0; i < EEPROM_SIZE; i++)
{
//store data into ROM_WR_DATA register
*(uint32_t*)(ROM_WR_DATA) = blockdata[i];
Expand Down