Skip to content

libarc32_arduino101/Makefile: Strip libarc32drv_arduino101.a #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2017
Merged

libarc32_arduino101/Makefile: Strip libarc32drv_arduino101.a #381

merged 1 commit into from
Jan 9, 2017
+4 −0

Conversation

eriknyquist
Copy link
Contributor

@calvinatintel @SidLeung please review

@eriknyquist eriknyquist added this to the Deneb milestone Dec 30, 2016
@eriknyquist
Copy link
Contributor Author

FYI for testing, the effect of this change is that any code in the .a file is a black box during debugging.
For example, if you set a breakpoint at Serial.begin() in your sketch, then keep stepping down until you can go no further, you'll eventually reach some function from the .a file. You won't be able to step into it, or see any source lines inside the function. All you can do is step over it.

@SidLeung
Copy link
Contributor

When using JTAG debugger, libarc32drv_arduino101.a is recompiled so that the symbol table will use the path of the local source. In the Makefile, just comments to tell the user to comment out the stripping for debugging info. Similar to the comment in platform.txt. BTW, how much (flash) memory space is saved by stripping the symbol table info in the library?

@eriknyquist
Copy link
Contributor Author

@SidLeung are you sure? can you show me where that is happening?
AFAIK libarc32drv_arduino101.a doesn't get recompiled anywhere unless you run "make" yourself.

@eriknyquist
libarc32_arduino101/Makefile: Add 'strip' target
1c01334 
The file libarc32drv_arduino101.a is built with debugging symbols by
default, however the version we ship needs to be stripped. The new
"strip" target makes it easy for us to strip when committing, and
the default target still behaves the same way, so the library can be
re-compiled for debugging purposes
@eriknyquist
Copy link
Contributor Author

eriknyquist commented Jan 9, 2017 •
edited
Loading

OK, the final decision for this change is;

Default target for the .a file remains the same. When you run "make", it will build with debug symbols, and not be stripped. This means that CODK users can use "make" to re-build the .a file for debugging purposes.

Also, a new "strip" target has been added to the .a Makefile. Developers should use this target (i.e. "make strip") when re-building the .a file to check into version control.

Repeat: Use "make strip" when re-building libarc32drv_arduino101.a, if you are going to commit it. Otherwise, paths from the machine you are using will be embedded in the .a file, and will show up in GDB when CODK users try to debug

@SidLeung
Copy link
Contributor

SidLeung commented Jan 9, 2017

@eriknyquist Thanks for putting in the strip symbol info option in the Makefile. It looks good. @calvinatintel Please merge.

@eriknyquist eriknyquist merged commit 5d91dc6 into arduino:master Jan 9, 2017
@eriknyquist eriknyquist deleted the strip_libarc branch January 9, 2017 18:44
@eriknyquist eriknyquist mentioned this pull request Jan 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinatintel calvinatintel

@SidLeung SidLeung

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Deneb
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eriknyquist @SidLeung @calvinatintel