Jira 791: Sketch crash using both Firmata and BLE library, git #377 #411
Conversation
…#377 1. The BLEStream object adds profile when boot but the HW doesn't be initialized and makes APP crash. 2. Change the BLE initial process not depend on HW. Buffer the attributes if HW not initialized. 3. Changed files libraries/CurieBLE/src/BLEDevice.h - expose constructor libraries/CurieBLE/src/BLEPeripheral.cpp - not call HW init function libraries/CurieBLE/src/internal/BLEDeviceManager.cpp - change init order libraries/CurieBLE/src/internal/BLEProfileManager.cpp - change constructor
|
@bigdinotech @eriknyquist , please review the code change, thanks. |
| @@ -133,7 +133,8 @@ void BLEDeviceManager::poll() | |||
| } | |||
|
|
|||
| void BLEDeviceManager::end() | |||
There was a problem hiding this comment.
What's the reason for this empty function? Will it be implemented soon?
There was a problem hiding this comment.
Good point, Erik. Did talk to Liang about this issue.
The BLEDeviceManager class is a singleton. It is not expected to go away. However, it can end its operation and that's where end() can come in to tidy up its allocated resources. This will be done in the next release as part of the BLE performance improvement. Just create a Jira ticket #839 to track this task.
|
@yashaswini-hanji , would you please merge this PR to main trunk? Thanks. |
|
There is a conflict with this PR. Changes needs to be rebased. |
|
I already merged it. There was no conflict |
|
Please ignore previous message. Erik already merged these changes. |
|
@sandeepmistry , resolution is available in nightly build starting on 2/9/2017, http://mkfs.ndg.intel.com/json/public/package_public-07.4_index.json |
initialized and makes APP crash.
attributes if HW not initialized.
libraries/CurieBLE/src/BLEDevice.h - expose constructor
libraries/CurieBLE/src/BLEPeripheral.cpp - not call HW init function
libraries/CurieBLE/src/internal/BLEDeviceManager.cpp - change init order
libraries/CurieBLE/src/internal/BLEProfileManager.cpp - change constructor