-
-
Notifications
You must be signed in to change notification settings - Fork 213
Provide better info about the bootloader data #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@per1234 Any feedback? |
Memory usage change @ 091f7ce
Click for full report table
Click for full report CSV
|
String getClockSource(uint8_t flag) { | ||
switch (flag){ | ||
case 0x8: | ||
return "External clock (ST Link MCO)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the strings here as
External oscillator
External crystal
Internal clock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@facchinm Shall I create another PR for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup :)
With this PR the output of the bootloader info sketch should be easier to understand. It looks e.g. like the following: