Restore and use PINCOUNT_fn() wrapper #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
added a commit
to facchinm/ArduinoCore-renesas
that referenced
this pull request
Aug 25, 2023
The macro represents the number of pins that can be actively used "directly". Since A4/A5 are shared with SDA/SCL, the total number of unique gpios on UNO R4 headers is indeed 14+6 NUM_DIGITAL_PINS is currently unused in the core (better to use PINCOUNT arduino#107 for any safety check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
@WestfW this should fix the PINCOUNT macro being partially missing, while refactoring the code to use it.