Fixed hash algo to be selected based on input and not hardcoded #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @lagosantol. This change requires to rebuild the library linked by the SSLClient https://github.com/arduino/ArduinoCore-renesas/blob/main/libraries/SSLClient/src/cortex-m33/libmbedse05x.a Do you mind adding it to to this PR to keep things aligned? Otherwise i can do it for you, just let me know. You can follow this README to rebuild the library from the |
per1234
added
type: enhancement
|
Superseded by #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default SE05x configuration comes with 256 bit curves, so SHA256 is a better default choice.
Even better is to adapt to the input, in case the configuration is changed.