Ethernet.begin - fix parameters ordering #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
|
Hi @pennam ☕ 👋 Is the EthernetC33 library used anywhere in the Arduino IoT Cloud stack yet? If not I'd be willing to merge this change. |
|
the IoT Cloud lib uses the ConnectionHandler lib and that uses the mac address version of |
|
I've also checked, let's move ahead then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author of the STM32Ethernet library decided to change the ordering of the parameters for
beginwithoutmacaddress parameter. The EthernetC33 library is based on the STM32Ethernet library and the ordering of the parameters was not fixed.The library is not yet used by many. It requires the Portenta C33 and a Portenta shield with Ethernet PHY module. So lets change the ordering of the parameters as soon as possible.