EthernetC33 debugging #223
Merged
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this branch is kept from merging by the license/cla check not bring signed. Can you sign the CLA agreement? Likely you've already signed it, but maybe you made this commit with a different email address? (This is a known cause for CLA errors). |
aentinger
force-pushed
the
ethernet_debugging
branch
from
f90c10a to
695dc02
Compare
aentinger
force-pushed
the
ethernet_debugging
branch
from
695dc02 to
fc6aad0
Compare
|
Update: wasn't a CLA issue but a merge conflict with |
JAndrassy
force-pushed
the
ethernet_debugging
branch
2 times, most recently
from
75e25c7 to
e9afdb0
Compare
|
Why the force-push? Now there's another merge-conflict 😉 . You'd have needed to |
|
sorry, the force push was just to start the check for the CLA. |
aentinger
force-pushed
the
ethernet_debugging
branch
from
e9afdb0 to
fc6aad0
Compare
|
Hi @JAndrassy ☕ 👋 can you check that your merges are in? (They should be). |
|
looks OK. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the missing
volatileonbool dhcp_acquiredin CNetIf.h caused problems for WiFi DHCP too. The waiting for DHCP ended only on timeout, but status() check then was OK because the IP address was set. So WiFi.begin just took long time.I use Uno R4 to test Renesas Core LwIP networking. For WiFi I have an esp32 with the Hosted firmware on SPI and for Ethernet I replaced the EthernetDriver implementation with one over the W5500 driver (Ethernet 2 shied) from the esp8266 core. So I use
Ethernet.beginmethods with the MAC address parameter where some of this bugs appeared. The missingrestartAsyncRequest();insetMacAddressstopped the periodic task so DHCP then timed out. After that I had in EthernetDriver a buffer smaller than the DHCP packet and the code just hang. It was the the assert in CEth::output).tested with LegacyEthernetTest
EthernetDriverW5500.cpp should work on Portenta C33 with MKR ETH shield too