Fix in formula for creating frequency from MIDI note #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stated formula for converting midi-notes to frequency is wrong – the base and exponent of the second factor should be interchanged
|
|
|
add more context to the title of the PR. the current title doesn't make sense in the context of the whole Renesas platform repo |
aentinger
changed the title
per1234
added
type: imperfection
per1234
reviewed
Jul 12, 2024
|
@per1234 please check again.. my correction reflects the formula stated in the wikipedia article. The formula in the current file does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stated formula for converting midi-notes to frequency is wrong – the base and exponent of the second factor should be interchanged