Skip to content

Add completion for PowerShell #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 26, 2021

Conversation

manchoz
Copy link
Contributor

@manchoz manchoz commented Aug 25, 2021

Add support to generate PowerShell completions for arduino-cli in PowerShell 5.0+

This PR:

  • Add PowerShell to completion code generation

While waiting for documentation, please, you can test it following the instructions at Autocomplete in PowerShell.

@manchoz manchoz marked this pull request as draft August 25, 2021 11:27
@manchoz manchoz marked this pull request as ready for review August 25, 2021 14:43
@manchoz
Copy link
Contributor Author

manchoz commented Aug 25, 2021

Add tests and documentation.

@umbynos @per1234 please, review.

Let me know if I need to squash the commits.

@manchoz manchoz changed the title [WIP] Add completion for PowerShell Add completion for PowerShell Aug 25, 2021
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and it works great, I think there's only need for that small docs edit and then it's good to go for me.

@silvanocerza
Copy link
Contributor

Let me know if I need to squash the commits.

No worries, it will be squashed when merged.

@manchoz manchoz requested a review from silvanocerza August 26, 2021 08:10
@silvanocerza silvanocerza merged commit 804b8d0 into arduino:master Aug 26, 2021
@manchoz manchoz deleted the mnx_powershell_completion branch August 26, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants