Skip to content

Add gRPC interface function to request user fields supported by a board/protocol combination #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Adds a new gRPC interface function.

  • What is the current behavior?

gRPC clients have no way to know if a board/protocol combination requires custom user fields.

  • What is the new behavior?

gRPC clients can now call SupportedUserFields to get a mapping of user fields supported by the specified board/protocol combination.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Oct 11, 2021
@silvanocerza silvanocerza requested a review from a team October 11, 2021 15:09
@silvanocerza silvanocerza self-assigned this Oct 11, 2021
@silvanocerza silvanocerza force-pushed the scerza/grpc-user-field-request branch from 26e30ce to 6cbead0 Compare October 11, 2021 15:10
@silvanocerza silvanocerza merged commit 39d9b69 into master Oct 11, 2021
@silvanocerza silvanocerza deleted the scerza/grpc-user-field-request branch October 11, 2021 15:48
d-a-v pushed a commit to d-a-v/arduino-cli that referenced this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants