Skip to content

[skip changelog] Sync install docs from "template" #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2021
Merged

[skip changelog] Sync install docs from "template" #1544

merged 4 commits into from
Nov 11, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 11, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Documentation enhancement and fix

  • What is the current behavior?

A defect fix and multiple improvements have been made to the upstream "template" installation documentation which this project's installation docs are based on:

https://github.com/arduino/tooling-project-assets/blob/main/other/installation-script/installation.md

The defect is present in this repository's installation instructions and the improvements are not.

  • What is the new behavior?

This repository's installation documentation is at the state of the art.

No breaking change.

This document provides a list of installation options. The user may pick any one option that is most convenient for them.
However, a reader might get the impression that it is a list of instructions that must be followed from top to bottom.

An introduction makes the situation immediately clear to the reader.
A significant portion of Arduino users use Windows. The first option listed in the installation instructions is for an
installation shell script, which can be used on Windows, but might not be convenient for some Windows users.

This could be discouraging or frustrating to potential new users, but not necessarily so because the script is an
optional convenience and directly downloading and installing the tool is also an option, as documented in the
instructions for the second listed option.

A little refinement of the wording of the script's `sh` requirement makes the situation clear to those users.
A reference link provides easy access to the relevant information for readers who are not familiar with this concept
while not harming readability for everyone else by increasing verbosity.
This document is intended to provide a list of installation options:

- brew
- script
- download
- build

but the heading levels were misaligned, which resulted in this structure:

-brew
- script
  - download
  - build
@per1234 per1234 added type: enhancement Proposed improvement topic: documentation Related to documentation for the project labels Nov 11, 2021
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Nov 11, 2021
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@per1234 per1234 merged commit 1243277 into arduino:master Nov 11, 2021
@per1234 per1234 deleted the sync-install-docs branch November 11, 2021 09:08
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants