Skip to content

Relax markdown link-check timeouts #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 14, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
This is a test to see if this change helps markdown link checker to pass.

@cmaglie cmaglie marked this pull request as ready for review June 14, 2022 12:14
@cmaglie cmaglie requested a review from a team June 14, 2022 12:14
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Jun 14, 2022
@cmaglie cmaglie force-pushed the relax_link_check branch from 74d88dc to f8efd2c Compare June 14, 2022 12:37
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is difficult to determine whether this provides a solution because I see even with the previous configuration the job is now passing:

https://github.com/arduino/arduino-cli/actions/runs/2495322429

It was failing earlier on the nightly build links. I noticed that the nightly build has been failing for the last two days (it did pass when I re-ran it, after the time of the failing check), which correlated with the appearance of these failures of the link check on the nightly build links.

the retryCount configuration is specific to a 429 HTTP response code. I see the checks were marked failing as "Status: 0". I don't know what the significance of that is.

Anyway, I don't think it does any harm, so I guess it is worth a try as an experiment.

@cmaglie cmaglie merged commit 8b631ff into arduino:master Jun 14, 2022
@cmaglie cmaglie deleted the relax_link_check branch June 14, 2022 14:25
@per1234 per1234 added the type: enhancement Proposed improvement label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants