Skip to content

Check json logs entries in compile and upload python integration tests #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Sep 4, 2019

This PR adds log lines assertions in a "white box" fashion in the python integration testing suite to allow a more flexible testing

The is_message_in_json_log_lines is_message_sequence_in_json_log_traces function is not optimized as the log produced for each test is currently very small

@rsora rsora force-pushed the rsora/integ-test-json branch from b7bfbb0 to 004d599 Compare September 5, 2019 14:13
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsora rsora merged commit 7e255e9 into master Sep 5, 2019
@rsora rsora deleted the rsora/integ-test-json branch September 5, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants