Use patched invoke in e2e requirements #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
suggested changes
Sep 24, 2019
| @@ -2,7 +2,7 @@ astroid==2.2.5 | |||
| atomicwrites==1.3.0 | |||
| attrs==19.1.0 | |||
| importlib-metadata==0.18 | |||
| invoke==1.3.0 | |||
| git+https://github.com/flazzarini/invoke.git | |||
There was a problem hiding this comment.
Can we add a comment here stating this is temporary?
added 3 commits
September 24, 2019 10:32
In order to overcome issue reported here #416 we used successfully this patch pyinvoke/invoke#661 in the requirements.txt so we re-enable the test pipeline step for e2e tests on win
rsora
force-pushed
the
rsora/e2e-patch
branch
from
0f482fb to
671ce52
Compare
cmaglie
approved these changes
Sep 24, 2019
masci
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a patched version of
invokein order to overcome flaky test issue reported in previous PR #416, and reported also from other users in theinvokerepo (pyinvoke/invoke#660).This PR applies the following changes:
test/requirements.txttestGH Actions workflowpytestto 3.5.1 intest/requirements.txt