Skip to content

add workflow to check certs expiring date #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2020
Merged

add workflow to check certs expiring date #569

merged 2 commits into from
Nov 9, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 9, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?
  • What is the new behavior?

This workflow checks the expiration date of our Windows and macOS sign certificates and reports their expiring date if needed. Thank you @per1234

  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos added the CI label Nov 9, 2020
@umbynos umbynos self-assigned this Nov 9, 2020
@umbynos umbynos requested a review from zmoog November 9, 2020 09:15
zmoog
zmoog approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@zmoog zmoog merged commit 1da694d into devel Nov 9, 2020
@zmoog zmoog deleted the umbynos/check_certs_workflow branch November 9, 2020 11:00
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @zmoog @per1234