Skip to content

Pin github actions virtual environment versions #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 26, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
  • What is the current behavior?

ubuntu-latest will be an alias to ubuntu-20.04 instead of ubuntu-18.04 actions/runner-images#1816

  • What is the new behavior?

I've pinned github actions virtual environments to an explicit version to not get unexpected behaviours.

  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos self-assigned this Nov 26, 2020
@umbynos umbynos added the CI label Nov 26, 2020
@umbynos umbynos requested a review from zmoog November 27, 2020 08:41
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbynos umbynos merged commit d71d3ec into devel Nov 27, 2020
@umbynos umbynos deleted the umbynos/pin_gh_runners branch November 27, 2020 09:20
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants