Skip to content

add virustotal scan to CI release workflow #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 24, 2020
Merged

add virustotal scan to CI release workflow #580

Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6031620
add virustotal scan to CI release workflow
umbynos Dec 21, 2020
7df5910
add virustotal separate workflow
umbynos Dec 22, 2020
ff3b995
Revert "add virustotal scan to CI release workflow"
umbynos Dec 22, 2020
72b3fe7
workflows fails with `Cannot send Error [ERR_FR_MAX_BODY_LENGTH_EXCEE…
umbynos Dec 22, 2020
5550c7e
try fix from https://github.com/crazy-max/ghaction-virustotal/pull/64
umbynos Dec 22, 2020
3310b8b
Revert the two previous commits: problem solved in the GHA
umbynos Dec 22, 2020
b7df792
Try again virustotal scan in CI release workflow
umbynos Dec 22, 2020
6f5b5d5
use analysis output from virustotal action to put links in release body
umbynos Dec 23, 2020
16e7d23
remove `released.yml` because it was useless at this point
umbynos Dec 23, 2020
228a93a
fix set-output truncating multiple lines
umbynos Dec 23, 2020
5d45c38
add title to links added in the release
umbynos Dec 23, 2020
80c5a68
remove github token (not needed)
umbynos Dec 23, 2020
7ac9059
refactor release body (use dropdown: less confusing for the user)
umbynos Dec 23, 2020
8021657
solve body formatted wrong
umbynos Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,14 +410,34 @@ jobs:
rm -v release/._ArduinoCreateAgent*.dmg
mv -v ArduinoCreateAgent-windows*/* release/

- name: VirusTotal Scan
id: virustotal_step
uses: crazy-max/ghaction-virustotal@v2
with:
vt_api_key: ${{ secrets.VIRUSTOTAL_API_KEY }}
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we trust this 3rd party action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing it does is uploading binaries to virustotal. I don't see the problem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the github token is not required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used to update the release artifacts?

Copy link
Contributor Author

@umbynos umbynos Dec 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but it's not used because the workflow is not triggered by a release (The trigger is on:push:tags)

update_release_body: false # `true` won't work becasue trigger type is not release
files: |
release/*.exe
arduino-create-agent-windows-2019-386/arduino-create-agent.exe
arduino-create-agent-windows-2019-amd64/arduino-create-agent.exe

- name: Organize release body message #use sed to clean and format the output markdown style
id: release_body
run: |
vt_title="## VirusTotal analysis 🛡: %0A"
vt_links="$(echo ${{ steps.virustotal_step.outputs.analysis}} | sed 's/release\///g' | sed 's/,/\n/g' | sed 's/^/- [/' | sed 's/=/](/' | sed 's/$/)/')"
vt_links="${vt_links//$'\n'/'%0A'}" # replace \n with a special character -> generates a single lines, \n will be reintroduced later
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.community/t/set-output-truncates-multiline-strings/16852/3

echo "::set-output name=RBODY::$vt_title$vt_links"

- name: Create Github Release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: ${{ github.ref }}
body: ""
body: ${{ steps.release_body.outputs.RBODY}}
draft: false
prerelease: ${{ steps.prerelease.outputs.IS_PRE }}

Expand Down