Rename FirmwareUpdater to FirmwareUploader #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI checks are failing because I changed also links to the repo. |
silvanocerza
suggested changes
Apr 21, 2021
|
I did not rename these two files and not updated the readme accordingly because they are used in the js lib. Regarding the template: |
silvanocerza
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated binary name (from FirmwareUpdater to FirmwareUploader) in the CI / Taskfiles / .gitignore.
I think it's a bit confusing to use both FirmwareUploader and FirmwareUpdater in the same GitHub repo though.. I've renamed also the repo handle. The only thing missing is to rename the repo name in settings.