Add script to generate json containing information to run fwuploader tool #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
reviewed
May 25, 2021
generator/generator.py
Outdated
|
|
||
|
|
||
| # Generate and copy all firmware binary data for specified board | ||
| def create_firmware_data(simple_fqbn, binary, module, version): |
There was a problem hiding this comment.
Suggested change
| def create_firmware_data(simple_fqbn, binary, module, version): | |
| def create_firmware_data(binary, module, version): |
not used
generator/generator.py
Outdated
Comment on lines
85
to
90
| for l in boards_txt: | ||
| board_id = fqbn.split(":")[2] | ||
| if l.startswith(f"{board_id}.upload"): | ||
| (k, v) = l.strip().split("=", maxsplit=1) | ||
| k = ".".join(k.split(".", maxsplit=1)[1:]) | ||
| board_upload_data[k] = v |
There was a problem hiding this comment.
Maybe this and code L98-102 could be put in a function since is basically the same code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generator.pyscript creates aboard_index.jsonfile that will be used by the FirmwareUploader tool to gather all the information necessary to run correctly, list of firmwares for each supported board, upload command to run, binary to loader Sketch. It also copies the necessary firmware and loader Sketch binaries in structured folders ready to be uploaded in the download server.As of now it uses a
raw_board.jsonfile that has been created using some information obtained using the--get_available_forflag that returns all available firmware for all each supported board.In the future we can use the
board_index.jsoncurrently in use as a base and add new information if necessary.The script assumes the Arduino CLI is installed and all supported boards' core too, it fails in case neither is found.
The script can be easily run like this:
It must be run inside the
generatorfolder where theraw_boards.jsonfile is stored. All generated folders and files will be saved in that same folder.