Skip to content

IDE2 must not use deprecated real_name gRPC API #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kittaakos opened this issue Oct 4, 2022 · 0 comments · Fixed by #1528
Closed
3 tasks done

IDE2 must not use deprecated real_name gRPC API #1525

kittaakos opened this issue Oct 4, 2022 · 0 comments · Fixed by #1528
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the problem

real_name has been removed from the CLI. arduino/arduino-cli#1890

IDE2 must adapt ASAP. Otherwise, IDE2 won't be able to use a pinned version of CLI from the arduino/arduino-ide due to breaking changes.

To reproduce

grep -rl --exclude-dir ./arduino-ide-extension/src/node/cli-protocol ".getRealName()" ./arduino-ide-extension/src/node
./arduino-ide-extension/src/node/library-service-impl.ts

Expected behavior

IDE2 is not using real_name

Arduino IDE version

945a8f4

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 4, 2022
@kittaakos kittaakos self-assigned this Oct 4, 2022
kittaakos pushed a commit that referenced this issue Oct 5, 2022
Removed real_name of the libraries.
6cdecad 
It has been removed from the gRPC API: arduino/arduino-cli#1890

This PR switches from `real_name` to `name` in the UI, as the `name` is
the canonical form provided by the CLI.

Closes #1525

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Oct 5, 2022
Merged
4 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1525 Removed the real_name of the libraries arduino/arduino-ide
2 participants
@kittaakos @per1234