Skip to content

fix: disable local windows signing for external contributions #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinato giacomocusinato commented Nov 7, 2024

Motivation

Change description

Disable windows signing for pull requests coming from forks.

Other information

Resolves #2545

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@giacomocusinato giacomocusinato changed the title fix: disable local windows signing for forks PR fix: disable local windows signing for forked PR Nov 7, 2024
@giacomocusinato giacomocusinato changed the title fix: disable local windows signing for forked PR fix: disable local windows signing for external contributions Nov 7, 2024
@giacomocusinato giacomocusinato force-pushed the #2545 branch 2 times, most recently from c33e735 to 13b9408 Compare November 7, 2024 15:37
@giacomocusinato giacomocusinato added topic: infrastructure Related to project infrastructure os: windows Specific to Windows operating system labels Nov 7, 2024
@giacomocusinato giacomocusinato merged commit 63e9dfd into arduino:main Nov 11, 2024
22 checks passed
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Specific to Windows operating system topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Windows build is broken for external contributors
3 participants