fix: use ElectronConnectionHandler to connect the ide updater frontend and the electron main process
#2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocusinato
temporarily deployed
to
production
GitHub Actions
Inactive
giacomocusinato
added
type: imperfection
giacomocusinato
changed the title
ElectronConnectionHandler to connect ide updater servicesElectronConnectionHandler to connect the ide updater frontend and the electron main process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2696
Change description
Use
ElectronConnectionHandlerinstead ofConnectionHandlerto establish communication between the frontend and the electron main process. This is needed specifically for services interacting with electron.Other information
The issue seems to appear also on the Theia IDE example. An issue will follow on Theia side.