Skip to content

Restore 1.x.x compatibility #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

Restore 1.x.x compatibility #22

merged 1 commit into from
May 10, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 10, 2023

This PR should revert the breaking change in 1.9.0, we should tag the release 1.9.1 after merging this one.

@cmaglie cmaglie self-assigned this May 10, 2023
@cmaglie cmaglie linked an issue May 10, 2023 that may be closed by this pull request
Breaking change to github.com/arduino/go-paths-helper.Path.IsInsideDir #21
Closed
@cmaglie cmaglie added type: bug Perceived defect in any part of project topic: code Related to content of the project itself labels May 10, 2023
@cmaglie
Copy link
Member Author

cmaglie commented May 10, 2023

We may also release a v2 version, and keep the API breaking change, but this will force consumers of this library to update their import path to:

github.com/arduino/go-paths-helper/v2

I don't think it's worth it.

@cmaglie cmaglie merged commit 7d88805 into master May 10, 2023
@cmaglie cmaglie deleted the restore-1.x-compatibility branch May 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: bug Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change to github.com/arduino/go-paths-helper.Path.IsInsideDir
2 participants
@cmaglie @alessio-perugini