Do not stop ReadDirRecursive* on broken symlinks

readdir.go

@@ -116,9 +116,7 @@ func (p *Path) ReadDirRecursiveFiltered(recursionFilter ReadDirFilter, filters .
 			}
 
 			if recursionFilter == nil || recursionFilter(path) {
-				if isDir, err := path.IsDirCheck(); err != nil {
-					return nil, err
-				} else if isDir {
+				if path.IsDir() {
 					subPaths, err := search(path)
 					if err != nil {
 						return nil, err

readdir_test.go

@@ -250,21 +250,11 @@ func TestReadDirRecursiveFiltered(t *testing.T) {
 func TestReadDirRecursiveLoopDetection(t *testing.T) {
 	loopsPath := New("testdata", "loops")
 	unbuondedReaddir := func(testdir string) (PathList, error) {
-		// This is required to unbound the recursion, otherwise it will stop
-		// when the paths becomes too long due to the symlink loop: this is not
-		// what we want, we are looking for an early detection of the loop.
-		skipBrokenLinks := func(p *Path) bool {
-			_, err := p.Stat()
-			return err == nil
-		}
-
 		var files PathList
 		var err error
 		done := make(chan bool)
 		go func() {
-			files, err = loopsPath.Join(testdir).ReadDirRecursiveFiltered(
-				skipBrokenLinks,
-			)
+			files, err = loopsPath.Join(testdir).ReadDirRecursive()
 			done <- true
 		}()
 		require.Eventually(
@@ -313,4 +303,18 @@ func TestReadDirRecursiveLoopDetection(t *testing.T) {
 		pathEqualsTo(t, "testdata/loops/regular_2/dir2/dir1/file1", l[4])
 		pathEqualsTo(t, "testdata/loops/regular_2/dir2/file2", l[5])
 	}
+
+	{
+		l, err := unbuondedReaddir("regular_3")
+		require.NoError(t, err)
+		require.Len(t, l, 7)
+		l.Sort()
+		pathEqualsTo(t, "testdata/loops/regular_3/dir1", l[0])
+		pathEqualsTo(t, "testdata/loops/regular_3/dir1/file1", l[1])
+		pathEqualsTo(t, "testdata/loops/regular_3/dir2", l[2])
+		pathEqualsTo(t, "testdata/loops/regular_3/dir2/dir1", l[3])
+		pathEqualsTo(t, "testdata/loops/regular_3/dir2/dir1/file1", l[4])
+		pathEqualsTo(t, "testdata/loops/regular_3/dir2/file2", l[5])
+		pathEqualsTo(t, "testdata/loops/regular_3/link", l[6]) // broken symlink is reported in files
+	}
 }

testdata/loops/regular_3/dir2/dir1

@@ -0,0 +1 @@
+../dir1

testdata/loops/regular_3/link

@@ -0,0 +1 @@
+broken