Remove non-functional bold tags from Mermaid code #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make it easier for the reader to understand the function of complementary example workflows provided in the FAQ, a chart is used to explain the flow of sketches report data between the steps and jobs in the sketch compilation workflow and between the sketch compilation workflow and the deltas report workflow. The Mermaid diagramming language is used to produce this flowchart (GitHub automatically renders Mermaid code in code blocks of Markdown files). The text in charts can be styled and formatted using HTML tags in the Mermaid code. Previously, bold tags were used on the subgraph titles in order to improve the readability of the chart. Since the time the chart was created, something changed in GitHub's Markdown/Mermaid rendering system that causes these tags to no longer cause the intended text styling. They now are simply printed as text, meaning they now have a harmful effect on the readability. For this reason, the tags are hereby removed. No alternative is available. The line break tags continue to work as expected (though unfortunately the text is now left aligned instead of being centered as before) so they are retained.
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make it easier for the reader to understand the function of complementary example workflows provided in the FAQ, a chart is used to explain the flow of sketches report data between the steps and jobs in the sketch compilation workflow and between the sketch compilation workflow and the deltas report workflow.
The Mermaid diagramming language is used to produce this flowchart (GitHub automatically renders Mermaid code in
mermaidcode blocks of Markdown files).The text in charts can be styled and formatted using HTML tags in the Mermaid code. Previously,
<b>tags were used on the subgraph titles in order to improve the readability of the chart. Since the time the chart was created, something changed in GitHub's Markdown/Mermaid rendering system that causes these tags to no longer cause the intended text styling. They now are simply printed as text, meaning they now have a harmful effect on the readability:For this reason, the tags are hereby removed. No alternative is available. The
instead of being centered as before) so they are retained.
<br />tags continue to work as expected (though unfortunately the text is now left aligned