Skip to content

Update go-serial to fix Windows crash #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 2, 2023

Fix Windows crashes when the board is disconnected while enumerating USB.

See also:
bugst/go-serial#138
bugst/go-serial#153

@cmaglie cmaglie self-assigned this Jan 2, 2023
Fix Windows crash when the board is disconnected while enumerating USB.

See also:
bugst/go-serial#138
bugst/go-serial#153
@cmaglie cmaglie force-pushed the fix_windows_enumerator branch from b41a45e to 9e152f6 Compare January 2, 2023 14:00
@cmaglie cmaglie added priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project criticality: high Of high impact labels Jan 2, 2023
@cmaglie
Copy link
Member Author

cmaglie commented Jan 2, 2023

@per1234 may you ask someone on the forum to test this version of the serial-discovery?

@per1234
Copy link
Contributor

per1234 commented Jan 3, 2023

Thanks @cmaglie. I have requested assistance with testing from the users:

https://forum.arduino.cc/t/no-ports-discovered-of-ide-2-0-0-rc9-rc9-1/1018669/47

I will report the findings as soon as I hear anything.

@per1234
Copy link
Contributor

per1234 commented Jan 3, 2023

User feedback received:

https://forum.arduino.cc/t/no-ports-discovered-of-ide-2-0-0-rc9-rc9-1/1018669/48

You, guys, are, amazing! Tested with several boards and a separate usb hub, all appear to be working flawlessly.

@cmaglie cmaglie merged commit d274e93 into main Jan 4, 2023
@cmaglie cmaglie deleted the fix_windows_enumerator branch January 4, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: high Of high impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants