Skip to content

fix: use shadow dom to prevent css leak #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: use shadow dom to prevent css leak #13

merged 2 commits into from
Oct 17, 2023

Conversation

bluecco
Copy link
Contributor

@bluecco bluecco commented Oct 17, 2023

style kept after the change:
BEFORE:

unframed
image

image

local dapp
image

image

AFTER:

unframed still the same
image

image image

@bluecco bluecco requested review from gergold and vladutjs October 17, 2023 14:39
janek26
janek26 approved these changes Oct 17, 2023
View reviewed changes
@janek26 janek26 merged commit ec82fae into develop Oct 17, 2023
@bluecco bluecco deleted the fix/css-leak branch October 27, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janek26 janek26 janek26 approved these changes

@vladutjs vladutjs vladutjs approved these changes

@gergold gergold Awaiting requested review from gergold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluecco @janek26 @vladutjs