fix: remove trailing whitespace and newlines from type and auth type (#543)

* fix: remove trailing whitespace and newlines from type and auth type

* chore: prepare for 1.16.2 release

Author: werne2j

Diff for: docs/installation.md

@@ -80,7 +80,7 @@ spec:
         # Note the lack of the `v` prefix unlike the git tag
         env:
           - name: AVP_VERSION
-            value: "1.16.1"
+            value: "1.16.2"
         args:
           - >-
             wget -O argocd-vault-plugin
@@ -115,7 +115,7 @@ RUN apt-get update && \
     rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
 
 # Install the AVP plugin (as root so we can copy to /usr/local/bin)
-ENV AVP_VERSION=1.16.1
+ENV AVP_VERSION=1.16.2
 ENV BIN=argocd-vault-plugin
 RUN curl -L -o ${BIN} https://github.com/argoproj-labs/argocd-vault-plugin/releases/download/v${AVP_VERSION}/argocd-vault-plugin_${AVP_VERSION}_linux_amd64
 RUN chmod +x ${BIN}
@@ -190,7 +190,7 @@ spec:
         image: registry.access.redhat.com/ubi8
         env:
           - name: AVP_VERSION
-            value: 1.16.1
+            value: 1.16.2
         command: [sh, -c]
         args:
           - >-
@@ -274,7 +274,7 @@ RUN apt-get update && \
     rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
 
 # Install the AVP plugin (as root so we can copy to /usr/local/bin)
-ENV AVP_VERSION=1.16.1
+ENV AVP_VERSION=1.16.2
 ENV BIN=argocd-vault-plugin
 RUN curl -L -o ${BIN} https://github.com/argoproj-labs/argocd-vault-plugin/releases/download/v${AVP_VERSION}/argocd-vault-plugin_${AVP_VERSION}_linux_amd64
 RUN chmod +x ${BIN}

Diff for: manifests/cmp-configmap/argocd-repo-server-deploy.yaml

@@ -29,7 +29,7 @@ spec:
         # Note the lack of the `v` prefix unlike the git tag
         env:
           - name: AVP_VERSION
-            value: "1.16.1"
+            value: "1.16.2"
         args:
           - >-
             wget -O argocd-vault-plugin

Diff for: manifests/cmp-sidecar/argocd-repo-server.yaml

@@ -25,7 +25,7 @@ spec:
         image: registry.access.redhat.com/ubi8
         env:
           - name: AVP_VERSION
-            value: 1.16.1
+            value: 1.16.2
         command: [sh, -c]
         args:
           - >-

Diff for: pkg/config/config.go

@@ -72,12 +72,14 @@ func New(v *viper.Viper, co *Options) (*Config, error) {
 		utils.VerboseToStdErr("%s: %s\n", k, viperValue)
 	}
 
-	authType := v.GetString(types.EnvAvpAuthType)
+	authType := strings.TrimSpace(v.GetString(types.EnvAvpAuthType)) // strip whitespace and newlines
 
 	var auth types.AuthType
 	var backend types.Backend
 
-	switch v.GetString(types.EnvAvpType) {
+	backendType := strings.TrimSpace(v.GetString(types.EnvAvpType)) // strip whitespace and newlines
+
+	switch backendType {
 	case types.VaultBackend:
 		{
 			apiClient, err := api.NewClient(api.DefaultConfig())

Diff for: pkg/config/config_test.go

@@ -54,7 +54,7 @@ func TestNewConfig(t *testing.T) {
 		},
 		{
 			map[string]interface{}{
-				"AVP_TYPE":      "vault",
+				"AVP_TYPE":      "vault\n",
 				"AVP_AUTH_TYPE": "k8s",
 				"AVP_K8S_ROLE":  "role",
 			},