Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove trailing whitespace and newlines from type and auth type #543

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Aug 24, 2023

Description

remove trailing whitespace and newlines from type and auth type

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@werne2j werne2j self-assigned this Aug 24, 2023
@werne2j werne2j requested a review from jkayani as a code owner August 24, 2023 17:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Merging #543 (a17d6a1) into main (5084eca) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   71.29%   71.32%   +0.02%     
==========================================
  Files          26       26              
  Lines        1951     1953       +2     
==========================================
+ Hits         1391     1393       +2     
  Misses        460      460              
  Partials      100      100              
Files Coverage Δ
cmd/util.go 76.92% <100.00%> (ø)
pkg/auth/vault/kubernetes.go 64.70% <100.00%> (ø)
pkg/config/config.go 84.52% <100.00%> (+0.12%) ⬆️
pkg/utils/util.go 59.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@werne2j werne2j merged commit 8209627 into main Oct 21, 2023
@werne2j werne2j deleted the whitespace branch October 21, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants