Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added keeper secrets manager backend #468

Merged

Conversation

robbert229
Copy link
Contributor

Description

This PR adds Keeper Secrets Manager as a supported backend for argocd-vault-plugin. I have implemented, and tested the main use cases, but have not implemented support for versions, annotations, or keeper secrets manager's file attachment system. It does however support most of the types of secrets you commonly want to get out of KSM.

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • [] Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

N/A

@robbert229 robbert229 force-pushed the feature/add-keepersecurity-backend branch 3 times, most recently from 85ffb2d to e7ef35d Compare February 24, 2023 20:50
@codecov-commenter
Copy link

Codecov Report

Merging #468 (85ffb2d) into main (8043640) will increase coverage by 0.16%.
The diff coverage is 80.00%.

❗ Current head 85ffb2d differs from pull request most recent head e7ef35d. Consider uploading reports for the commit e7ef35d to get more accurate results

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   77.36%   77.53%   +0.16%     
==========================================
  Files          23       24       +1     
  Lines        1498     1598     +100     
==========================================
+ Hits         1159     1239      +80     
- Misses        252      268      +16     
- Partials       87       91       +4     
Impacted Files Coverage Δ
pkg/config/config.go 83.78% <75.00%> (-0.51%) ⬇️
pkg/backends/keepersecretsmanager.go 80.68% <80.68%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robbert229 robbert229 force-pushed the feature/add-keepersecurity-backend branch from e7ef35d to b49fef3 Compare February 24, 2023 20:58
Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know Keeper secret manager very well, so trusting the implementation.

@werne2j werne2j merged commit c8c85c1 into argoproj-labs:main Mar 7, 2023
@robbert229 robbert229 deleted the feature/add-keepersecurity-backend branch July 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants