Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): replace aws-sdk-go with aws-sdk-go-v2 #472

Merged
merged 1 commit into from
Mar 11, 2023
Merged

chore(deps): replace aws-sdk-go with aws-sdk-go-v2 #472

merged 1 commit into from
Mar 11, 2023

Conversation

nvachhar
Copy link
Contributor

@nvachhar nvachhar commented Feb 28, 2023 •
edited
Loading

Description

aws-sdk-go-v2 supports more formats of AWS configuration. In particular, it supports the sso-session configuration
section.

Fixes: #473

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@nvachhar nvachhar marked this pull request as ready for review February 28, 2023 14:18
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #472 (1059cf9) into main (c8c85c1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          24       24           
  Lines        1610     1610           
=======================================
  Hits         1251     1251           
  Misses        268      268           
  Partials       91       91
Impacted Files Coverage Δ
pkg/backends/awssecretsmanager.go 71.05% <100.00%> (ø)
pkg/config/config.go 83.78% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvachhar
Copy link
Contributor Author

nvachhar commented Mar 6, 2023

@werne2j and @jkayani - is there a process I need to follow to get code review?

werne2j
werne2j approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvachhar Just some patience. Once the conflicts are resolved we can merge this in.

werne2j
werne2j reviewed Mar 7, 2023
View reviewed changes
go.mod Outdated
@@ -53,6 +53,12 @@ require (
sigs.k8s.io/yaml v1.3.0
)

require (
github.com/aws/aws-sdk-go-v2 v1.17.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you actually move this to the above require block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this up to the earlier require block (not sure how this extra one got added in the first place). But I also moved github.com/aws/aws-sdk-go to the lower require block since it is only an indirect dependency.

@nvachhar
Copy link
Contributor Author

nvachhar commented Mar 8, 2023

@nvachhar Just some patience. Once the conflicts are resolved we can merge this in.

Didn't mean to be impatient. I've worked in different open source projects where I missed a step and never got a review :-D

chore(deps): replace aws-sdk-go with aws-sdk-go-v2
1059cf9 
aws-sdk-go-v2 supports more formats of AWS configuration. In particular,
it supports the sso-session configuration
[section](https://docs.aws.amazon.com/cli/latest/userguide/sso-configure-profile-token.html#sso-configure-profile-token-manual).

Signed-off-by: Neil Vachharajani <[email protected]>
@nvachhar
Copy link
Contributor Author

nvachhar commented Mar 8, 2023

All conflicts are resolved and the go.mod cleaned up. Thank you!

@werne2j werne2j merged commit 703c093 into argoproj-labs:main Mar 11, 2023
@nvachhar nvachhar deleted the aws-sdk-go-v2 branch May 23, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werne2j werne2j werne2j approved these changes

@jkayani jkayani Awaiting requested review from jkayani jkayani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvachhar @codecov-commenter @werne2j