Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awssecrets): add support for binary #500

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

JBOClara
Copy link
Contributor

@JBOClara JBOClara commented Apr 23, 2023

Description

We use SecretBinary has key part to retreive binary data from AWS Secrets Manager.

Fixes: #499

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Signed-off-by: Julien Boulanger <[email protected]>
@JBOClara JBOClara force-pushed the feat/support-binaryString branch from a23c815 to 6ce7756 Compare April 23, 2023 14:44
@codecov-commenter
Copy link

Codecov Report

Merging #500 (6ce7756) into main (359a636) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   75.31%   75.38%   +0.07%     
==========================================
  Files          25       25              
  Lines        1689     1694       +5     
==========================================
+ Hits         1272     1277       +5     
  Misses        323      323              
  Partials       94       94              
Impacted Files Coverage Δ
pkg/backends/awssecretsmanager.go 69.56% <100.00%> (+3.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JBOClara!

@werne2j werne2j merged commit 717f1c0 into argoproj-labs:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants