-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go version to 1.21 #565
Conversation
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 71.29% 71.29%
=======================================
Files 26 26
Lines 1951 1951
=======================================
Hits 1391 1391
Misses 460 460
Partials 100 100
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -7,7 +7,7 @@ quality: | |||
go test -race -v -coverprofile cover.out ./... | |||
|
|||
build: | |||
go build -o ${BINARY} . | |||
go build -buildvcs=false -o ${BINARY} . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue with the Linux build https://github.com/argoproj-labs/argocd-vault-plugin/actions/runs/6526155961/job/17719605595
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just 1 question
Description
Update go version to 1.21
Fixes:
https://github.com/argoproj-labs/argocd-vault-plugin/security/dependabot/37 & https://github.com/argoproj-labs/argocd-vault-plugin/security/dependabot/36
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17
to ensure only the minimum is pulled in.Type of Change
Other information