Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade aws-sdk-go-v2 #644

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Timothy-Dement
Copy link
Contributor

Description

AWS Secrets Manager functionality is broken in version v1.18.0 due to aws/aws-sdk-go-v2#2370.

As referenced in that issue and in the comment by @sneaker-xc3 here, the fix is to upgrade the aws-sdk-go-v2 dependencies:

go get -u github.com/aws/aws-sdk-go-v2/...

That has been done in this pull request, along with the required tidy command:

go mod tidy -compat=1.21

Fixes: #643

Checklist

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

As @sneaker-xc3 noted here, it would be good for this to prompt a new version release - Homebrew pulls down v1.18.0 which does not work with AWS Secrets Manager currently.

Signed-off-by: Timothy-Dement <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (42a43f0) to head (a1bd8ce).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   72.16%   73.55%   +1.38%     
==========================================
  Files          26       26              
  Lines        1994     1588     -406     
==========================================
- Hits         1439     1168     -271     
+ Misses        458      315     -143     
- Partials       97      105       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@werne2j werne2j merged commit fc452cd into argoproj-labs:main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants