ApplicationSet: Add RepositoryID to generated parameters for scmProvider
#15820
Labels
Comments
boris154
changed the title
scmProvider
crenshaw-dev
added
the
component:application-sets
|
I will take this up! /assign |
nikzayn
added a commit
to nikzayn/argo-cd
that referenced
this issue
Oct 13, 2023
…mProvider (argoproj#15820) Signed-off-by: nikzayn <[email protected]>
|
@nikzayn Any progress on this? I noticed that the pullRequest generator requires the ID, which would be nice to get from scmProvider with matrix generator. |
|
I will do it by next week!
Nikhil Vaidyar
…On Tue, 21 Nov 2023 at 4:22 PM, Toni Mauno ***@***.***> wrote:
@nikzayn <https://github.com/nikzayn> Any progress on this? I noticed
that the pullRequest generator requires the ID, which would be nice to get
from scmProvider.
—
Reply to this email directly, view it on GitHub
<#15820 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF74VOV6BOLMHGCMGL2ZN5LYFSBV3AVCNFSM6AAAAAA5TZUX26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGY4DCMBYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Add RepositoryID as part of the generated parameters in
scmProviderMotivation
In most cases when we need to get details for certain repo, using the name / namespace of the repo will required additional API call (first to search for the ID and then for the specific repo). By exposing the RepositoryID, we will be able to utilize it in various tools.
Proposal
From what it looks like, most (if not all) of the SCM providers already has the RepositoryID parameter. It should be exposed as a generated parameter.
The text was updated successfully, but these errors were encountered: