Feature/15820 #15953
Feature/15820 #15953
Conversation
…er from headers Signed-off-by: nikzayn <[email protected]>
…mProvider (argoproj#15820) Signed-off-by: nikzayn <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15953 +/- ##
==========================================
- Coverage 49.68% 49.68% -0.01%
==========================================
Files 267 267
Lines 46362 46362
==========================================
- Hits 23036 23035 -1
+ Misses 21067 21066 -1
- Partials 2259 2261 +2
☔ View full report in Codecov by Sentry. |
I see no such description... Looking at #15820, this is intended to be used as some cache but it's not clear at this time how that is intended to work... |
| @@ -339,7 +339,7 @@ spec: | |||
| - name: argocd-server | |||
| port: 80 | |||
| - kind: Rule | |||
| match: Host(`argocd.example.com`) && Headers(`Content-Type`, `application/grpc`) | |||
| match: Host(`argocd.example.com`) && Header(`Content-Type`, `application/grpc`) | |||
There was a problem hiding this comment.
Looking at the Traefik Rules, Headers seems to actually be correct
| @@ -432,6 +432,7 @@ type SCMProviderGenerator struct { | |||
| // Values contains key/value pairs which are passed directly as parameters to the template | |||
| Values map[string]string `json:"values,omitempty" protobuf:"bytes,11,name=values"` | |||
| AWSCodeCommit *SCMProviderGeneratorAWSCodeCommit `json:"awsCodeCommit,omitempty" protobuf:"bytes,12,opt,name=awsCodeCommit"` | |||
| RepositoryID string `json:"repositoryId,omitempty" protobuf:"bytes,13,opt,name=repositoryId"` | |||
There was a problem hiding this comment.
make codegen has to be run for the relevant code to be generated.
|
Closing for now, since this PR seems to be incomplete. Feel free to reopen once the requested changes have been amended. |
Checklist:
scmProvider#15820]" or "Fixes [ApplicationSet: Add RepositoryID to generated parameters forscmProvider#15820]" in the description to automatically close the associated issue.