Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add target branch support for bitbucket cloud pull request gener… #22402

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

CMDMichalKoval
Copy link

Fix #22005

@CMDMichalKoval CMDMichalKoval requested a review from a team as a code owner March 19, 2025 09:12
Copy link

bunnyshell bot commented Mar 19, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@CMDMichalKoval CMDMichalKoval force-pushed the bugfix/add-target-branch-bitbucket-cloud branch from 0fe88ba to 7eb28a4 Compare March 19, 2025 09:18
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.99%. Comparing base (0ec46f6) to head (3ea8e53).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22402      +/-   ##
==========================================
- Coverage   56.06%   55.99%   -0.08%     
==========================================
  Files         343      343              
  Lines       57568    57569       +1     
==========================================
- Hits        32274    32233      -41     
- Misses      22649    22676      +27     
- Partials     2645     2660      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add unit tests?

@CMDMichalKoval
Copy link
Author

Thanks for the PR! Could you add unit tests?

Done

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @CMDMichalKoval !!

Could you also update the documentation explaining the new field here ?

@CMDMichalKoval CMDMichalKoval requested a review from a team as a code owner March 24, 2025 17:00
@CMDMichalKoval
Copy link
Author

@ishitasequeira I have updated the docs and added more examples for filters

@CMDMichalKoval
Copy link
Author

@crenshaw-dev @ishitasequeira can you look at this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

targetBranchMatch filter does not work with pullRequest generator for Bitbucket Cloud
3 participants