-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli/app/diff): respect refresh type when running which specified revision (#22463) #22462
base: master
Are you sure you want to change the base?
fix(cli/app/diff): respect refresh type when running which specified revision (#22463) #22462
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
91d7fc5
to
aeb4261
Compare
…revision Signed-off-by: Josef Kolář <[email protected]>
…revision Signed-off-by: Josef Kolář <[email protected]>
73d9032
to
cf920d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22462 +/- ##
=========================================
Coverage ? 55.97%
=========================================
Files ? 343
Lines ? 57433
Branches ? 0
=========================================
Hits ? 32150
Misses ? 22643
Partials ? 2640 ☔ View full report in Codecov by Sentry. |
Would be good to have some unit tests with this new field. |
Also did you look into if is possible to fix the root problem with revision-based caching? Instead of a boolean flag, implement a caching mechanism that automatically invalidates the cache when a different revision is requested. This may be more complex, but a good long-term solution so user's don't have to explicitly pass a flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some tests to validate this?
Closes #22463
Checklist: