Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/app/diff): respect refresh type when running which specified revision (#22463) #22462

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thejoeejoee
Copy link

@thejoeejoee thejoeejoee commented Mar 24, 2025

Closes #22463

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@thejoeejoee thejoeejoee requested a review from a team as a code owner March 24, 2025 16:42
Copy link

bunnyshell bot commented Mar 24, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@thejoeejoee thejoeejoee force-pushed the fix-app-revision-diff-cache branch from 91d7fc5 to aeb4261 Compare March 24, 2025 16:42
@thejoeejoee thejoeejoee marked this pull request as draft March 24, 2025 16:42
@thejoeejoee thejoeejoee force-pushed the fix-app-revision-diff-cache branch from 73d9032 to cf920d1 Compare March 24, 2025 16:47
@thejoeejoee thejoeejoee changed the title fix(cli/app/diff): respect refresh type when running which specified revision fix(cli/app/diff): respect refresh type when running which specified revision (#22463) Mar 24, 2025
@thejoeejoee thejoeejoee marked this pull request as ready for review March 24, 2025 16:56
@thejoeejoee thejoeejoee requested a review from a team as a code owner March 24, 2025 16:56
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f8b5b0b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #22462   +/-   ##
=========================================
  Coverage          ?   55.97%           
=========================================
  Files             ?      343           
  Lines             ?    57433           
  Branches          ?        0           
=========================================
  Hits              ?    32150           
  Misses            ?    22643           
  Partials          ?     2640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pjiang-dev
Copy link
Contributor

Would be good to have some unit tests with this new field.
Also we'll need to update documentation and provide thorough description for what the new flag does

@pjiang-dev
Copy link
Contributor

Also did you look into if is possible to fix the root problem with revision-based caching? Instead of a boolean flag, implement a caching mechanism that automatically invalidates the cache when a different revision is requested. This may be more complex, but a good long-term solution so user's don't have to explicitly pass a flag.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some tests to validate this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd app diff --revision ignores hard refresh
3 participants