fix(argo-cd): hard coded .selector.matchLabels (#603)

* fix(argo-cd): hard coded .selector.matchLabels

it fixes #602

Signed-off-by: abdennour <[email protected]>

* style(argo-cd): linting circle ci

 error    too many blank lines

it fixes #602

Signed-off-by: abdennour <[email protected]>

* chore(argo-cd): adding myself to codeowners

it is related to #602

Signed-off-by: abdennour <[email protected]>

* chore(argo-cd): CODEOWNER work by invitation

related to #603 #602

Signed-off-by: abdennour <[email protected]>

* fix(argo-cd): Add info in README about labels

Signed-off-by: Sean Johnson <[email protected]>

Co-authored-by: Sean Johnson <[email protected]>

Author: abdennour

charts/argo-cd/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: 1.8.4
 description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 2.14.7
+version: 2.14.8
 home: https://github.com/argoproj/argo-helm
 icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
 keywords:

charts/argo-cd/README.md

@@ -14,6 +14,10 @@ This chart currently installs the non-HA version of ArgoCD.
 
 ## Upgrading
 
+### 2.14.7 and above
+
+The `matchLabels` key in the ArgoCD Appliaction Controller is no longer hard-coded. Note that labels are immutable so caution should be exercised when making changes to this resource.
+
 ### 2.10.x to 2.11.0
 
 The application controller is now available as a `StatefulSet` when the `controller.enableStatefulSet` flag is set to true. Depending on your Helm deployment this may be a downtime or breaking change if enabled when using HA and will become the default in 3.x.

charts/argo-cd/templates/argocd-application-controller/deployment.yaml

@@ -14,7 +14,7 @@ metadata:
 spec:
   selector:
     matchLabels:
-      app.kubernetes.io/name: {{ include "argo-cd.name" . }}-application-controller
+      app.kubernetes.io/name: {{ include "argo-cd.name" . }}-{{ .Values.controller.name }}
       app.kubernetes.io/instance: {{ .Release.Name }}
   {{- if  .Values.controller.enableStatefulSet }}
   serviceName: {{ template "argo-cd.controller.fullname" . }}