fix(argo-cd): hard coded .selector.matchLabels #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdennour
requested review from
davidkarlsen,
seanson,
spencergilbert and
yann-soubeyrand
as code owners
it fixes argoproj#602 Signed-off-by: abdennour <[email protected]>
abdennour
force-pushed
the
hotfix/label-selector-match
branch
from
7ce9ec1 to
d6df60b
Compare
error too many blank lines it fixes argoproj#602 Signed-off-by: abdennour <[email protected]>
it is related to argoproj#602 Signed-off-by: abdennour <[email protected]>
seanson
suggested changes
Mar 2, 2021
CODEOWNERS
Outdated
| @@ -4,7 +4,7 @@ | |||
| /charts/argo @stefansedich @paguos @vladlosev @yann-soubeyrand | |||
|
|
|||
| # Argo CD | |||
| /charts/argo-cd @seanson @spencergilbert @davidkarlsen @mr-sour @yann-soubeyrand | |||
| /charts/argo-cd @seanson @spencergilbert @davidkarlsen @mr-sour @yann-soubeyrand @abdennour | |||
There was a problem hiding this comment.
CODEOWNER changes are done typically by one of the ArgoCD owners (such as #551). if you'd like to volunteer to be a contributor please give a shout in the #argo-helm Slack channel.
There was a problem hiding this comment.
Looks good but needs the CODEOWNERS change removed.
Done! I removed it.
@seanson @vladlosev kindly proceed
vladlosev
reviewed
Mar 2, 2021
related to argoproj#603 argoproj#602 Signed-off-by: abdennour <[email protected]>
abdennour
commented
Mar 5, 2021
CODEOWNERS
Outdated
| @@ -4,7 +4,7 @@ | |||
| /charts/argo @stefansedich @paguos @vladlosev @yann-soubeyrand | |||
|
|
|||
| # Argo CD | |||
| /charts/argo-cd @seanson @spencergilbert @davidkarlsen @mr-sour @yann-soubeyrand @abdennour | |||
| /charts/argo-cd @seanson @spencergilbert @davidkarlsen @mr-sour @yann-soubeyrand | |||
There was a problem hiding this comment.
@seanson this is done as per reviewer's request
|
@seanson requested changes. And i applied these changes. |
Signed-off-by: Sean Johnson <[email protected]>
seanson
approved these changes
Mar 7, 2021
|
Looks good, thanks @abdennour! |
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
* fix(argo-cd): hard coded .selector.matchLabels it fixes argoproj#602 Signed-off-by: abdennour <[email protected]> * style(argo-cd): linting circle ci error too many blank lines it fixes argoproj#602 Signed-off-by: abdennour <[email protected]> * chore(argo-cd): adding myself to codeowners it is related to argoproj#602 Signed-off-by: abdennour <[email protected]> * chore(argo-cd): CODEOWNER work by invitation related to argoproj#603 argoproj#602 Signed-off-by: abdennour <[email protected]> * fix(argo-cd): Add info in README about labels Signed-off-by: Sean Johnson <[email protected]> Co-authored-by: Sean Johnson <[email protected]>
|
Welcome @seanson ! I want to give a TALK in ArgoCon. Could you please facilitate it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it fixes #602
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.