-
Notifications
You must be signed in to change notification settings - Fork 278
chore: Bump Kubernetes clients to 1.29.2 #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 54.71% 55.25% +0.54%
==========================================
Files 41 41
Lines 4834 4821 -13
==========================================
+ Hits 2645 2664 +19
+ Misses 1977 1945 -32
Partials 212 212 ☔ View full report in Codecov by Sentry. |
7c3b952
to
99b2b78
Compare
|
Hi @leoluz. Could you review it ? Thanks. |
Hi, @pasha-codefresh . Could you review this PR ? Thanks. |
@sivchari are you still up for working on this? I have some time to help. |
Hi, @crenshaw-dev I've finished it, so could you check these changes ? |
@sivchari took a quick glance through, and it's looking good. Would you mind opening an Argo CD PR pointing at your gitops-engine fork so we can run those tests as well? Here's an example of how that looks: https://github.com/argoproj/argo-cd/pull/16967/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R296 |
Hi @crenshaw-dev I've already opened the PR in ArgoCD. The following link is it and the only thing that I should do is to pass the CI. Thanks. |
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sivchari!
This PR aims to updating Kubernetes version to 1.29.1