Skip to content

Commit ad930c7

Browse files
VitalyVPinchukashishkumar468
authored andcommitted
Add commons-app#3723 and commons-app#3721 to 2.13 release, fix conflicts
Conflicts were caused by merging commons-app#3723 before commons-app#3721 , so I just rolled both into one commit.
1 parent 54e8b95 commit ad930c7

File tree

1 file changed

+23
-26
lines changed

1 file changed

+23
-26
lines changed

app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java

Lines changed: 23 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
11
package fr.free.nrw.commons.nearby.fragments;
22

3-
import static fr.free.nrw.commons.contributions.MainActivity.CONTRIBUTIONS_TAB_POSITION;
4-
import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.LOCATION_SIGNIFICANTLY_CHANGED;
5-
import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.LOCATION_SLIGHTLY_CHANGED;
6-
import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.MAP_UPDATED;
7-
import static fr.free.nrw.commons.nearby.Label.TEXT_TO_DESCRIPTION;
8-
import static fr.free.nrw.commons.utils.LengthUtils.formatDistanceBetween;
9-
import static fr.free.nrw.commons.wikidata.WikidataConstants.PLACE_OBJECT;
10-
113
import android.Manifest;
124
import android.app.AlertDialog;
135
import android.content.BroadcastReceiver;
@@ -19,8 +11,6 @@
1911
import android.graphics.Bitmap;
2012
import android.os.Bundle;
2113
import android.provider.Settings;
22-
import android.text.Html;
23-
import android.text.method.LinkMovementMethod;
2414
import android.util.Log;
2515
import android.view.Gravity;
2616
import android.view.LayoutInflater;
@@ -36,15 +26,14 @@
3626
import android.widget.SearchView;
3727
import android.widget.TextView;
3828
import android.widget.Toast;
29+
3930
import androidx.annotation.NonNull;
4031
import androidx.annotation.Nullable;
41-
import androidx.appcompat.widget.AppCompatTextView;
4232
import androidx.recyclerview.widget.DividerItemDecoration;
4333
import androidx.recyclerview.widget.LinearLayoutManager;
4434
import androidx.recyclerview.widget.RecyclerView;
4535
import androidx.vectordrawable.graphics.drawable.VectorDrawableCompat;
46-
import butterknife.BindView;
47-
import butterknife.ButterKnife;
36+
4837
import com.google.android.material.bottomsheet.BottomSheetBehavior;
4938
import com.google.android.material.chip.Chip;
5039
import com.google.android.material.chip.ChipGroup;
@@ -69,6 +58,17 @@
6958
import com.mapbox.pluginscalebar.ScaleBarOptions;
7059
import com.mapbox.pluginscalebar.ScaleBarPlugin;
7160
import com.pedrogomez.renderers.RVRendererAdapter;
61+
62+
import fr.free.nrw.commons.utils.DialogUtil;
63+
import java.util.ArrayList;
64+
import java.util.List;
65+
import java.util.concurrent.TimeUnit;
66+
67+
import javax.inject.Inject;
68+
import javax.inject.Named;
69+
70+
import butterknife.BindView;
71+
import butterknife.ButterKnife;
7272
import fr.free.nrw.commons.CommonsApplication;
7373
import fr.free.nrw.commons.R;
7474
import fr.free.nrw.commons.Utils;
@@ -92,7 +92,6 @@
9292
import fr.free.nrw.commons.nearby.Place;
9393
import fr.free.nrw.commons.nearby.contract.NearbyParentFragmentContract;
9494
import fr.free.nrw.commons.nearby.presenter.NearbyParentFragmentPresenter;
95-
import fr.free.nrw.commons.utils.DialogUtil;
9695
import fr.free.nrw.commons.utils.ExecutorUtils;
9796
import fr.free.nrw.commons.utils.LayoutUtils;
9897
import fr.free.nrw.commons.utils.LocationUtils;
@@ -106,13 +105,16 @@
106105
import io.reactivex.Observable;
107106
import io.reactivex.android.schedulers.AndroidSchedulers;
108107
import io.reactivex.schedulers.Schedulers;
109-
import java.util.ArrayList;
110-
import java.util.List;
111-
import java.util.concurrent.TimeUnit;
112-
import javax.inject.Inject;
113-
import javax.inject.Named;
114108
import timber.log.Timber;
115109

110+
import static fr.free.nrw.commons.contributions.MainActivity.CONTRIBUTIONS_TAB_POSITION;
111+
import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.LOCATION_SIGNIFICANTLY_CHANGED;
112+
import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.LOCATION_SLIGHTLY_CHANGED;
113+
import static fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType.MAP_UPDATED;
114+
import static fr.free.nrw.commons.nearby.Label.TEXT_TO_DESCRIPTION;
115+
import static fr.free.nrw.commons.utils.LengthUtils.formatDistanceBetween;
116+
import static fr.free.nrw.commons.wikidata.WikidataConstants.PLACE_OBJECT;
117+
116118

117119
public class NearbyParentFragment extends CommonsDaggerSupportFragment
118120
implements NearbyParentFragmentContract.View,
@@ -152,8 +154,6 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment
152154
MapView mapView;
153155
@BindView(R.id.rv_nearby_list)
154156
RecyclerView rvNearbyList;
155-
@BindView(R.id.tv_attribution)
156-
AppCompatTextView tvAttribution;
157157

158158
@Inject LocationServiceManager locationManager;
159159
@Inject NearbyController nearbyController;
@@ -236,8 +236,8 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
236236
UiSettings uiSettings = mapBoxMap.getUiSettings();
237237
uiSettings.setCompassGravity(Gravity.BOTTOM | Gravity.LEFT);
238238
uiSettings.setCompassMargins(12, 0, 0, 24);
239-
uiSettings.setLogoEnabled(false);
240-
uiSettings.setAttributionEnabled(false);
239+
uiSettings.setLogoEnabled(true);
240+
uiSettings.setAttributionEnabled(true);
241241
uiSettings.setRotateGesturesEnabled(false);
242242
NearbyParentFragment.this.isMapBoxReady=true;
243243
performMapReadyActions();
@@ -260,9 +260,6 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
260260
scaleBarPlugin.create(scaleBarOptions);
261261
});
262262
});
263-
264-
tvAttribution.setText(Html.fromHtml(getString(R.string.map_attribution)));
265-
tvAttribution.setMovementMethod(LinkMovementMethod.getInstance());
266263
}
267264

268265
/**

0 commit comments

Comments
 (0)