Skip to content

update SignalR.Client to 8.0.x #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samples/AckableChatRoom/AckableChatRoom.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>
</Project>
3 changes: 2 additions & 1 deletion samples/AdvancedChatRoom/AdvancedChatRoom.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net8?

<UserSecretsId>advancedchatroom</UserSecretsId>
Expand All @@ -11,6 +11,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="7.0.8" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this one to 8.*?

<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions samples/BlazorChat/BlazorChat.csproj
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net8?

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="7.0.8" />
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>

Expand Down
3 changes: 2 additions & 1 deletion samples/ChatRoom/ChatRoom.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net8?

<Nullable>enable</Nullable>
Expand All @@ -7,6 +7,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>

Expand Down
3 changes: 2 additions & 1 deletion samples/FlightMap/FlightMap.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to net8?

<UserSecretsId>flightmap</UserSecretsId>
Expand All @@ -10,6 +10,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions samples/GitHubChat/GitHubChat.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

<ItemGroup>
<PackageReference Include="AspNet.Security.OAuth.GitHub" Version="7.0.4" />
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions samples/ServerSideBlazor/ServerSideBlazor.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
</ItemGroup>

Expand Down
4 changes: 2 additions & 2 deletions samples/SimpleEcho/SimpleEcho.csproj
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<UserSecretsId>2da0d60d-9962-455e-97af-f0d2668c4ea1</UserSecretsId>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Azure.SignalR" Version="1.*" />
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="7.0.8" />
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="8.0.13" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 8.* instead of sticky to one version?

</ItemGroup>
</Project>