This repository was archived by the owner on Dec 19, 2018. It is now read-only.
[Prototype] Event counters #886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, still don't like that these are JSON-ified in the payload instead of their own columns... Did we have a particular need in mind for adding these? Or just general diagnostics? |
kichalla
force-pushed
the
kichalla/add-eventsource
branch
from
3c3d4b8 to
e251272
Compare
kichalla
force-pushed
the
kichalla/add-eventsource
branch
from
09bd0ea to
d04421d
Compare
kichalla
force-pushed
the
kichalla/add-eventcounter
branch
from
47ceec2 to
ae38e83
Compare
kichalla
force-pushed
the
kichalla/add-eventsource
branch
from
b20e587 to
4abb48e
Compare
kichalla
force-pushed
the
kichalla/add-eventcounter
branch
from
ae38e83 to
071d2ee
Compare
kichalla
force-pushed
the
kichalla/add-eventcounter
branch
from
071d2ee to
cf3d5da
Compare
kichalla
force-pushed
the
kichalla/add-eventcounter
branch
from
cf3d5da to
9ce2de3
Compare
|
@kichalla this needs an update after @benaadams PR. |
kichalla
force-pushed
the
kichalla/add-eventcounter
branch
from
9ce2de3 to
6e6bec6
Compare
|
@davidfowl sure, updated |
benaadams
reviewed
Feb 17, 2017
| @@ -146,7 +148,7 @@ public void DisposeContext(Context context, Exception exception) | |||
| if (eventLogEnabled) | |||
| { | |||
| // Non-inline | |||
| hostingEventLog.RequestStop(); | |||
| hostingEventLog.RequestStop(startTimestamp, currentTimestamp); | |||
There was a problem hiding this comment.
Both values could be zero
There was a problem hiding this comment.
Ah, you check in the call
|
Closing this as we are not taking it in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidfowl @rynowak
EventCountersis an event that is logged for the interval time (in seconds) that we specify. Here the interval has been set as 1 sec. There is a timer which keeps writing out an EventCounters event for every event counter that is created and so you see the mean, standard deviation, count to be NaN initially (when the client hasn't made requests yet). Regarding using this data, just as any other event source event, theseEventCountersevents can be processed via the TraceEvent nuget package and a UI could be built on top of it (if you are trying to compare the experience of perfmon).