-
Notifications
You must be signed in to change notification settings - Fork 43
Roslyn binaries not copied properly on publish in 1.0.6 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have experienced problems too with 1.0.6 on a full .NET app using Roslyn compiler for scripting purposes. |
Thanks for reporting the issue. I'll take a look. |
Sent PR 14 |
@onyxmaster You're picture made my day... To me it looks like an expression of, "Come'on, REALLY?" (Which is certainly how I feel now...) |
Had the same issue. Downgrading to 1.0.5 works. thanks guys. |
Having the same problem, in vs 2017, downgrading to 1.0.5 works |
whatever this issue is, it has totally hosed our build. Even after rolling back to 1.0.5, I still get an error about not being able to find 1.0.6 assembly. Edit: My problem was I didn't have web.config checked in so it was still seeing 1.0.6. Running build now to test theory. Seriously though Jinhuafei needs to run his code through multiple environments. |
I have seen issues where on the build server, for some reason unless you delete the downloaded source code, it keeps old files. Delete manually and then try to rebuild again. |
Yeah, it was the web.config that was the hold up. Roll back to 1.0.5 does work for me now. VS2k15u3 |
Happens here with VS2017 15.2 (26430.16) Release when publishing to file, and "Precompile during publishing" is checked. If we uncheck this option, the publish succeeds. Not on all publishing, just some profiles. And deleting/recreating profile doesn't helps. |
Hi, I had started a question on this last week over on Stack Overflow. It can be found at: Rohit submitted an answer to my question with a work-around. The issue appears to lie with the Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props file in the build\net45 directory. Hopefully the developers can work out why the changes they've made in this release related to how the RoslyCompilerFiles are copied don't appear to be working in VS2015 or VS2017. Les |
@TheDestinyGroup If you can't wait for the new release, you can copy the CS in this PR to workaround the issue for now. |
Had same problem. Downgrading to 1.0.5 worked. |
Same issue here. .csproj created in VS2017 that had never touched VS2015. Like others, uninstalling and then installing 1.0.5 worked. 1.0.6 should probably be pulled from nuget. |
We have the same issue with 1.0.7. |
@IvanAlekseev can you give us more details? We tested 1.0.7 version with all the publishing scenarios in VS and didn't see any issue. |
@Jinhuafei We have used via VSTS App Service Publish and Azure App Service GitHub deployment. Both have the same issue. |
@erincerol thanks. I'll take a look. |
FWIW I had exactly the same problem using VS Azure Publish. I uninstalled 1.0.5 directly then installed 1.0.7 clean back into the project and it fixed the problem. When I upgraded the package from 1.0.5 to 1.0.7 it failed. I don't think it's the publish method but rather the copying of the compiler into the publish directory that is failing. Runs fine locally even if the pub is broken. I have diff's of my csproj, packages.config and web.config that I can DM you if you like. I can also roll back and reproduce the problem exactly if you have an update you'd like to test. |
1.0.7 Fixed the issue for me in team services. Thanks |
I opened a new issue to track the publish issues that 1.0.7 release doesn't fix. |
1.0.7 worked for me when publishing to azure using web deploy |
had same issue with teamcity and octopus on 1.0.7 |
I rolled back from v1.0.7 to v1.0.6 and it worked fine. |
@Jinhuafei Here Build started 30/08/2017 14:43:19. Deferred Messages Detailed Build Summary============================== Build Hierarchy (IDs represent configurations) =====================================================
|
@mobius127 from the error message "The target "go" does not exist in the project.", it doesn't seem related to the DotNetCompilerPlatform nupkg. |
@Jinhuafei but when I'm trying to publish in Azure my web application, fails because of it |
@mobius127 if you uninstall DotNetCompilerPlatform, are you able to publish your app to Azure? |
Uninstalling 1.0.7 then reinstall 1.0.7 will publish the assemblies but only once. The next publish will not publish them. This is using a local file path publish. |
There's two ways to get it to deploy. Seems switching publish profiles forces it to redeploy, however if you do a publish profile that has the "deletes all files" flag and deploy twice, the roslyn folder only is there on first deploy. It's not there any other deploys after. If you clean the site it will also redeploy without having to switch publish profiles. Rebuild will not work but clean will. |
My guess is many people may not being seeing this issue if they do not publish with "delete existing files" flag turned on. A temporary work around is to just uncheck "delete existing files" when working locally. |
@BobbyCannon thanks for the repro. I was able to repro the issue by publishing twice. The second publish doesn't build the project(nothing changed in the project), hence the copy rolsyn files task is not executed. Will look into a fix. |
Can we re-open this issue? Or create a new issue to track this since it clearly isnt fixed? BTW I have the same issues with 1.0.7 with Teamcity and Octopus. |
Is there a workaround on this issue besides copying and pasting the roslyn folder into the bin, i have tried using the version 1.0.5 of the dom compiler and have also set csc.exe as environment variable, however i checked through MSBuild im using c#5 i thought this could be the answer. |
@akash3456 would you please elaborate your issue? Are you talking about compiling the code behind file? Do you install RoslynCodeDomProvider nupkg in your project? |
So when I try to build a web project into an msi I was expecting to see the Roslyn folder in the bin folder of the project of installed files. But this was missing after installing code dom provider nuget package this didn't fix the issue but a manual intervention was required to build the Roslyn files from the source and add them in the msi.
…Sent from my iPhone
On 27 Sep 2017, at 17:09, Jinhuafei ***@***.***> wrote:
@akash3456 would you please elaborate your issue? Are you talking about compiling the code behind file? Do you install RoslynCodeDomProvider nupkg in your project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Can confirm also, at moment fighting with TeamCity and OctoPack, reverting package to 1.0.5 gives me roslyn folder inside bin, 1.0.7 - roslyn is missing. |
Seems fixed with 1.0.8 because with 1.0.7 and our TFSs build the /bin/roslyn folder was always missing after builds, now it is there. |
Seems to me every version after 1.0.5 does not copy roslyn into the bin folder even on a new simple console application. It work for me in 1.0.5, but it has the bug that was fixed in 1.0.6 with the hard coded path. |
Running into this issue in non-Web projects as well. WPF app in this case, same problem with 1.08. Reverting to 1.05 works. |
@RickStrahl see my previous comment and referenced issue. Adding "WebProjectOutputDir" variable to our csproj file worked in our WPF app. |
Ok thanks for identifying this as an issue. Will it work if I do specify webprojectoutputdir in settings?
…Sent from my iPhone
On 10 Nov 2017, at 23:17, William Bush ***@***.***> wrote:
@RickStrahl see my previous comment and referenced issue. Adding "WebProjectOutputDir" variable to our csproj file worked in our WPF app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@akash3456 Yes it will work, but it's a bit hacky. |
That’s not bad to be fair thanks for the effort
…Sent from my iPhone
On 11 Nov 2017, at 19:36, William Bush ***@***.***> wrote:
@akash3456 Yes it will work, but it's a bit hacky.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Upgrading from 1.0.7 to 1.0.8 solved it for me:
|
Upgrading to 1.0.8 hasn't solved the issue. We are using the "PackageReference" Nuget format. |
Having the same issue on TeamCity. If I run the publish profile locally What I have removed when upgrading to
because from my understanding it is not required anymore and with Any new insights on how to solve this? Why is TeamCity behaving differently... |
@Rzpeg @timmkrause can you provide msbuild log? |
@Jinhuafei I am sorry but unfortunately I am not allowed to do so... What came to my mind while reading the log was that the last build step which builds the project with
I fixed it now via a
I know this is a bit hacky but I need to make progress. Will keep an eye on this issue for a better solution. |
Ran into this with |
Using web publish from VS 2015 fails with the following:
Rolling back to 1.0.5 works.
I believe that the fix for #2 broke the web publish scenario at least with VS 2015.
This is a local path web publish with the following settings:
The text was updated successfully, but these errors were encountered: