This repository was archived by the owner on Dec 29, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Make Assert::command and with_args take AsRef<OsStr> args #59
Labels
Comments
Thanks for the feedback! I agree that it'd be a good thing for us to make the API more accepting of different string types, much like what was done with |
Yep, we should take |
epage
added a commit
to epage/assert_cli
that referenced
this issue
Oct 27, 2017
epage
added a commit
to epage/assert_cli
that referenced
this issue
Oct 27, 2017
epage
added a commit
to epage/assert_cli
that referenced
this issue
Oct 27, 2017
epage
added a commit
to epage/assert_cli
that referenced
this issue
Oct 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
First off, I just learned about assert_cli today and I'm excited to start using it!
All of the methods on
std::process:Command
for the executable name and commandline arguments takeT: AsRef<OsStr>
, so you can pass&str
but also&Path
and other useful things. It would be nice ifAssert::command
andAssert::with_args
took the same type of arguments so that users could pass in a larger variety of types.Specifically, I have the path to the executable I want to run as a
PathBuf
, so I can't pass it directly.This will require
Assert
to storecmd
asVec<OsString>
instead ofVec<String>
, but it shouldn't cause any issues.The text was updated successfully, but these errors were encountered: